Add wheel command to pyproject-build commands#305
Merged
stefanv merged 4 commits intoscientific-python:mainfrom Dec 2, 2025
Merged
Add wheel command to pyproject-build commands#305stefanv merged 4 commits intoscientific-python:mainfrom
stefanv merged 4 commits intoscientific-python:mainfrom
Conversation
stefanv
reviewed
Nov 28, 2025
|
|
||
|
|
||
| def test_wheel(example_pkg): | ||
| spin("wheel") |
Member
There was a problem hiding this comment.
Maybe should check for artifact?
Contributor
Author
There was a problem hiding this comment.
I added a simple presence test. Could you approve the workflows to have the tests run in ci?
Contributor
Author
|
Looks like the tests are working. @stefanv, do you consider them sufficient? Also, I don't think I have the power to add labels. Could you add an appropriate one and let me know if there is anything else for me to do? |
Member
|
Thanks, @zklaus! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a command to the pyproject-build commands that builds a wheel similar to the existing
sdistcommand.Closes #301.